Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform provider openstack to v2.0.0 #594

Merged
merged 3 commits into from
May 21, 2024
Merged

Upgrade terraform provider openstack to v2.0.0 #594

merged 3 commits into from
May 21, 2024

Conversation

guineveresaenger
Copy link
Contributor

This is a Major Version Upgrade.

Of note: terraform-provider-openstack released v2.0.0 but did not increase the version suffix in their go module file.

This pull request therefore updates terraform-provider-openstack to the resolving pseudoversion of the git sha of the v2.0.0 GitHub release tag.

Upstream migration guide for reference for deprecated resources

@guineveresaenger guineveresaenger added the needs-release/major When a PR with this label merges, it initiates a release of vX+1.0.0 label May 18, 2024
@guineveresaenger guineveresaenger requested review from a team and iwahbe May 18, 2024 23:47
@github-actions GitHub Actions
Copy link

github-actions bot commented May 18, 2024 •
edited
Loading

Does the PR have any schema changes?

Found 26 breaking changes:

Resources

  • "openstack:blockstorage/volume:Volume":
    • 🟡 inputs: "multiattach" missing
    • 🟡 properties: "multiattach" missing output "multiattach"
  • "openstack:blockstorage/volumeAttachV2:VolumeAttachV2":
    • 🟡 inputs: "instanceId" missing
    • 🟡 properties: "instanceId" missing output "instanceId"
  • "openstack:compute/instance:Instance":
    • inputs:
      • 🟡 "floatingIp" missing
      • 🟡 "volumes" missing
    • properties:
      • 🟡 "floatingIp" missing output "floatingIp"
      • 🟡 "volumes" missing output "volumes"
  • 🟡 "openstack:images/image:Image": properties: "updateAt" missing output "updateAt"
  • "openstack:loadbalancer/poolV1:PoolV1":
    • 🟡 inputs: "members" missing
    • 🟡 properties: "members" missing output "members"
  • "openstack:networking/router:Router":
    • 🟡 inputs: "externalGateway" missing
    • 🟡 properties: "externalGateway" missing output "externalGateway"
  • "openstack:networking/subnet:Subnet":
    • inputs:
      • 🟡 "allocationPoolsCollection" missing
      • 🟡 "hostRoutes" missing
    • properties:
      • 🟡 "allocationPoolsCollection" missing output "allocationPoolsCollection"
      • 🟡 "hostRoutes" missing output "hostRoutes"

Functions

  • "openstack:images/getImage:getImage": inputs:
    • 🟡 "sortDirection" missing input "sortDirection"
    • 🟡 "sortKey" missing input "sortKey"
  • "openstack:images/getImageIds:getImageIds": inputs:
    • 🟡 "sortDirection" missing input "sortDirection"
    • 🟡 "sortKey" missing input "sortKey"
  • 🟡 "openstack:networking/getSubnet:getSubnet": inputs: "dhcpDisabled" missing input "dhcpDisabled"

Types

  • 🟡 "openstack:compute/InstanceNetwork:InstanceNetwork": properties: "floatingIp" missing
  • 🔴 "openstack:compute/InstanceVolume:InstanceVolume" missing
  • 🔴 "openstack:networking/SubnetAllocationPoolsCollection:SubnetAllocationPoolsCollection" missing
  • 🔴 "openstack:networking/SubnetHostRoute:SubnetHostRoute" missing

New functions:

  • loadbalancer/getFlavorV2.getFlavorV2

Maintainer note: consult the runbook for dealing with any breaking changes.

@guineveresaenger guineveresaenger force-pushed the upgrade-terraform-provider-openstack-to-v2.0.0 branch from 1bdddcc to 0aa478d Compare May 19, 2024 00:19
VenelinMartinov
VenelinMartinov reviewed May 20, 2024
View reviewed changes
Makefile Outdated
@@ -14,7 +14,7 @@ PULUMI_CONVERT := 1

# Override during CI using `make [TARGET] PROVIDER_VERSION=""` or by setting a PROVIDER_VERSION environment variable
# Local & branch builds will just used this fixed default version unless specified
PROVIDER_VERSION ?= 3.0.0-alpha.0+dev
PROVIDER_VERSION ?= 4.0.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this keep the -alpha suffix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the ? that allowed the provider version action to override back to an alpa version (which resolves to v3 for module detection and thus the Go SDK build fails). I removed that for now.

We're considering improving https://github.com/pulumi/provider-version-action to correctly calculate a major version as well, which means we wouldn't have to set VERSION_PREFIX in .ci-mgmt.yaml anymore. For now, this should get overwritten in the nightly build.

@guineveresaenger guineveresaenger force-pushed the upgrade-terraform-provider-openstack-to-v2.0.0 branch from d2c1d82 to d25c1da Compare May 20, 2024 15:59
@guineveresaenger guineveresaenger merged commit 433b6c3 into master May 21, 2024
17 checks passed
@guineveresaenger guineveresaenger deleted the upgrade-terraform-provider-openstack-to-v2.0.0 branch May 21, 2024 15:31
@github-actions github-actions bot removed the needs-release/major When a PR with this label merges, it initiates a release of vX+1.0.0 label May 21, 2024
@iwahbe iwahbe mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinMartinov VenelinMartinov VenelinMartinov approved these changes

@iwahbe iwahbe iwahbe approved these changes

Assignees

@guineveresaenger guineveresaenger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guineveresaenger @iwahbe @VenelinMartinov